Make azure-json transitive in azure-core module-info #39432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
mssfang
approved these changes
Mar 27, 2024
|
@billwert Identity should now be able to use azure-json without changing module-info.java |
|
Yup. I'll pull it in before we release next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
azure-jsonrequiresin themodule-infoforazure-coretransitiveso downstream libraries don't need to add it asrequiredin theirmodule-infoas well.Libraries already requiring
azure-jsonin theirmodule-infowill need to be updated afterazure-corereleases as removing it now may break their build as they depend on released versions ofazure-corewhich don't perform transitive requires.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines